Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size info to bucket list api #122

Merged
merged 1 commit into from
May 18, 2020

Conversation

cesnietor
Copy link
Collaborator

@cesnietor cesnietor commented May 14, 2020

Using madmin.AccountUsageInfo since that api
includes size already.
Also includes integration with UI.

Screen Shot 2020-05-14 at 2 13 34 PM

Solves: #89

@cesnietor cesnietor requested review from Alevsk, dvaldivia and bexsoft May 14, 2020 21:14
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you looked at the AccountingUsageInfo API here ?

@dvaldivia
Copy link
Collaborator

Can you attach the information to the Bucket Details screen?

Screen Shot 2020-05-14 at 2 27 39 PM

Screen Shot 2020-05-14 at 2 27 32 PM

Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add bucket usage to bucket details screen

@cesnietor
Copy link
Collaborator Author

Have you looked at the AccountingUsageInfo API here ?

@harshavardhana I just checked it but it is pretty much giving the same stuff that I need, what's the added value?

@cesnietor
Copy link
Collaborator Author

cesnietor commented May 14, 2020

Add bucket usage to bucket details screen

@dvaldivia that's a different api, I'll send that in a separate pr for sake of simplicity

@harshavardhana
Copy link
Member

Have you looked at the AccountingUsageInfo API here ?

@harshavardhana I just checked it but it is pretty much giving the same stuff that I need, what's the added value?

It already has bucket information, it also shows if the bucket has read, write or read write access

@harshavardhana
Copy link
Member

Have you looked at the AccountingUsageInfo API here ?

@harshavardhana I just checked it but it is pretty much giving the same stuff that I need, what's the added value?

It already has bucket information, it also shows if the bucket has read, write or read write access

But it's per account basis ..

@cesnietor
Copy link
Collaborator Author

cesnietor commented May 14, 2020

Have you looked at the AccountingUsageInfo API here ?

@harshavardhana I just checked it but it is pretty much giving the same stuff that I need, what's the added value?

It already has bucket information, it also shows if the bucket has read, write or read write access

Ok, I'll take a look, I just want to make sure that if the crawl hasn't happened, it is still able to list the buckets, if this provides that then I can make only one call.

@cesnietor
Copy link
Collaborator Author

Have you looked at the AccountingUsageInfo API here ?

@harshavardhana I just checked it but it is pretty much giving the same stuff that I need, what's the added value?

It already has bucket information, it also shows if the bucket has read, write or read write access

Ok, I'll take a look, I just want to make sure that if the crawl hasn't happened, it is still able to list the buckets, if this provides that then I can make only one call.

@harshavardhana So based on our discussions what do you think about starting with this and continue with the enhancements as we go?

Alevsk
Alevsk previously approved these changes May 15, 2020
@cesnietor cesnietor changed the title Add size info to bucket list api [WIP] Add size info to bucket list api May 15, 2020
@cesnietor
Copy link
Collaborator Author

There are some changes coming in that we can leverage from: minio/minio#9607

dvaldivia
dvaldivia previously approved these changes May 15, 2020
@cesnietor
Copy link
Collaborator Author

Setting it as WIP.

@cesnietor cesnietor dismissed stale reviews from dvaldivia and Alevsk via 70294fe May 18, 2020 18:51
@cesnietor cesnietor force-pushed the usage-list-bucket branch from 519820c to 70294fe Compare May 18, 2020 18:51
@cesnietor cesnietor changed the title [WIP] Add size info to bucket list api Add size info to bucket list api May 18, 2020
@cesnietor
Copy link
Collaborator Author

Using now madmin.AccountUsageInfo

@cesnietor
Copy link
Collaborator Author

Have you looked at the AccountingUsageInfo API here ?

I've changed the code to make use of it.

dvaldivia
dvaldivia previously approved these changes May 18, 2020
Using madmin.AccountUsageInfo since that api
includes size already.
Also includes integration with UI.
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cesnietor cesnietor requested a review from harshavardhana May 18, 2020 20:27
@dvaldivia dvaldivia merged commit e8491d8 into minio:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants