-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add size info to bucket list api #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you looked at the AccountingUsageInfo API here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add bucket usage to bucket details screen
@harshavardhana I just checked it but it is pretty much giving the same stuff that I need, what's the added value? |
@dvaldivia that's a different api, I'll send that in a separate pr for sake of simplicity |
It already has bucket information, it also shows if the bucket has read, write or read write access |
But it's per account basis .. |
Ok, I'll take a look, I just want to make sure that if the crawl hasn't happened, it is still able to list the buckets, if this provides that then I can make only one call. |
@harshavardhana So based on our discussions what do you think about starting with this and continue with the enhancements as we go? |
There are some changes coming in that we can leverage from: minio/minio#9607 |
Setting it as WIP. |
519820c
to
70294fe
Compare
Using now madmin.AccountUsageInfo |
I've changed the code to make use of it. |
Using madmin.AccountUsageInfo since that api includes size already. Also includes integration with UI.
70294fe
to
f6110f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Using madmin.AccountUsageInfo since that api
includes size already.
Also includes integration with UI.
Solves: #89