Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Login assets and redirects relative #1854

Merged
merged 2 commits into from
Apr 17, 2022

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Apr 16, 2022

There's a bug when using subpath that prevents the login assets from loading relative to the serving path

Current:
Screen Shot 2022-04-15 at 6 54 27 PM

After Fix:

Screen Shot 2022-04-15 at 7 06 26 PM

To test:

Run MinIO Like

MINIO_CONSOLE_SUBPATH="/console/quack/" CI=true ./minio server /tmp/newdisk{1...4} --address :9001 --console-address :9091

start nginx with the following config

events { worker_connections 1024; }

http {

server {
    listen 8000;

    location /console/quack/ {
        rewrite   ^/console/quack/(.*) /$1 break;
        proxy_pass http://localhost:9091;
    }
}

}

Visit http://localhost:8000/console/quack/

Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@dvaldivia dvaldivia changed the title Make Login assets relative Make Login assets and redirects relative Apr 16, 2022
@dvaldivia dvaldivia merged commit 991cc09 into minio:master Apr 17, 2022
@dvaldivia dvaldivia deleted the login-assets-relative branch April 17, 2022 05:05
@fhaefemeier
Copy link

What exactly is the status of this feature? Is it official or still under development. I couldn't find any documentation on docs.min.io.
I'm really interested in this feature. I tried the set MINIO_CONSOLE_SUBPATH and add the LB rule to rewrite the path. But it isn't working. The login page is empty. I use the official docker image, version RELEASE.2022-06-11T19-55-32Z

@j13tw
Copy link

j13tw commented Jul 11, 2022

@fhaefemeier
Maybe you can follow the file to setting down your MINIO ENV below here
and in my testing, the ENV can work, finally version is on Container Image RELEASE.2022-06-17T02-00-35Z

https://github.com/minio/minio/blob/913e977c8d67b6d0117872d1af539a26ba8eb828/cmd/common-main.go#L187

SubPath = "CONSOLE_SUBPATH"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants