Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Session validation for MCS Operator Mode #191

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

dvaldivia
Copy link
Collaborator

Fixes the validation on the Session token for when we are running in MCS_OPERATOR_MODE

also MCS_MKUBE_OPERATOR_ONLY was renamed to MCS_OPERATOR_MODE

@dvaldivia dvaldivia requested review from Alevsk, cesnietor and bexsoft July 8, 2020 18:46
@dvaldivia dvaldivia self-assigned this Jul 8, 2020
bexsoft
bexsoft previously approved these changes Jul 8, 2020
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alevsk
Alevsk previously approved these changes Jul 8, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing it

@cesnietor
Copy link
Collaborator

please update k8s/base env variable

@cesnietor
Copy link
Collaborator

also this env variable needs to be documented

@dvaldivia
Copy link
Collaborator Author

@cesnietor this is a small change that unblocks @bexsoft , I'll update the env but since we no longer have dependencies on mkube I'll send a separate PR removing those dependencies, let's not add more changes to this PR

@dvaldivia dvaldivia dismissed stale reviews from Alevsk and bexsoft via 995a062 July 8, 2020 19:20
@cesnietor cesnietor self-requested a review July 8, 2020 19:29
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-07-08 at 12 25 44 PM

This is happening while trying to log in
│ 2020-07-08T19:25:28.3655455Z 2020/07/08 19:25:28 Get http://m3:8787/api/v1/tenants: dial tcp: lookup m3 on 1 │
│ 2020-07-08T19:25:28.3657217Z 2020/07/08 19:25:28 error login: invalid Credentials  

@dvaldivia
Copy link
Collaborator Author

@cesnietor it's trying to perform a reuqest to m3, which I wanted to address on separate PR, but then I just send the change, bare in mind if you are testing the login using kubectl proxy all requests will succeed, so test the login while running this inside the cluster

Alevsk
Alevsk previously approved these changes Jul 8, 2020
@cesnietor
Copy link
Collaborator

Screen Shot 2020-07-08 at 1 13 17 PM

this is happening:
Request URL: http://localhost:9090/api/v1/login/mkube
Request Method: POST
Status Code: 404 Not Found
Remote Address: [::1]:9090
Referrer Policy: no-referrer-when-downgrade

@cesnietor
Copy link
Collaborator

please make one single commit

@dvaldivia dvaldivia force-pushed the fix-session-passing-operator-mode branch from 38780d5 to db1fae1 Compare July 8, 2020 20:21
@dvaldivia
Copy link
Collaborator Author

@cesnietor done

@cesnietor cesnietor self-requested a review July 8, 2020 20:42
@cesnietor
Copy link
Collaborator

please make sure to edit the comments before squashing.

@dvaldivia dvaldivia merged commit 328133d into minio:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants