-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Session validation for MCS Operator Mode #191
Fix Session validation for MCS Operator Mode #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing it
please update k8s/base env variable |
also this env variable needs to be documented |
@cesnietor this is a small change that unblocks @bexsoft , I'll update the env but since we no longer have dependencies on mkube I'll send a separate PR removing those dependencies, let's not add more changes to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cesnietor it's trying to perform a reuqest to m3, which I wanted to address on separate PR, but then I just send the change, bare in mind if you are testing the login using |
please make one single commit |
38780d5
to
db1fae1
Compare
@cesnietor done |
please make sure to edit the comments before squashing. |
Fixes the validation on the Session token for when we are running in
MCS_OPERATOR_MODE
also
MCS_MKUBE_OPERATOR_ONLY
was renamed toMCS_OPERATOR_MODE