Fix download of folders #2891
Merged
Fix download of folders #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivaj05
requested review from
cniackz,
cesnietor,
allanrogerr,
dvaldivia,
prakashsvmx,
kaankabalak,
bexsoft and
jinapurapu
cesnietor
approved these changes
Jun 16, 2023
|
@reivaj05 I just noticed that on Chrome, the snackBar message doesn't show up like it does on Safari when downloading the folder. |
|
@cesnietor That's right, it doesn't show as in Safari, i wasn't sure if we want to display it in this case, Safari always downloads with the browser so we display the message all the time, it can be added if we want the same behavior for this case cc: @dvaldivia |
|
@reivaj05 yeah it indeed might not be needed since Chrome has a more visible indication on what's going on. |
dvaldivia
approved these changes
Jun 17, 2023
kaankabalak
approved these changes
Jun 18, 2023
prakashsvmx
approved these changes
Jun 19, 2023
bexsoft
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2890
Folders don't have a size attribute when they are retrieved from minio, i believe this is for design so new way to download in chunks won't work in this case, for the moment i'll let the browser handle the download as we do it for safari and later i'll check minio code if there is a way to send the size for folders to console