add encoded filename as part of upload url

[prakashsvmx]

pass encoded file name also as part of the url.

• Upload a single/multiole files
• Upload a folder
• Drag and drop
• upload under a prefix

the file name is part of prefix= parameter. parameter added for tooling support.

e.g:

http://localhost:5005/api/v1/buckets/test-bucket/objects/upload?prefix=dGVzdC1wcmVmaXgvMS5kb2M=
http://localhost:5005/api/v1/buckets/test-bucket/objects/upload?prefix=MS5wbmc=

[dvaldivia]

LGTM.

[cesnietor]

@prakashsvmx can we make it part of the same parameter prefix? all other apis have both, the path and the object in there. Otherwise the tooling app will have to do a corner case for this particular api.

[cesnietor]

please see comments

[prakashsvmx]

@cesnietor if prefix is passed, backend makes it as a folder. So I isolated it (and added code comments) to make it non breaking change.

[cesnietor]

@cesnietor if prefix is passed, backend makes it as a folder. So I isolated it (and added code comments) to make it non breaking change.

yes, in this case we would need to change the backend a bit. that's fine.
Instead of using prefix + file name it would have to be whole prefix.

_, err = client.putObject(ctx, params.BucketName, path.Join(prefix, path.Clean(p.FileName())), p, size, minio.PutObjectOptions{
			ContentType:      contentType,
			DisableMultipart: true, // Do not upload as multipart stream for console uploader.
		})

to :

_, err = client.putObject(ctx, params.BucketName, prefix,...

if it's not that simple, let me know, thanks @prakashsvmx

[prakashsvmx]

Thank you @cesnietor . I will check and update.

[cesnietor]

Tested LGTM, thanks @prakashsvmx !

[cesnietor]

I tried uploading a Folder with the following objects inside and some uploads failed

Requests failing:
http://localhost:5005/api/v1/buckets/bucket1/objects/upload?prefix=L2ZvbGRlcjEvZm9sZGVyMy8=cGRmd2l0aEFsZXJ0LnBkZg==
and
http://localhost:5005/api/v1/buckets/bucket1/objects/upload?prefix=L2ZvbGRlcjEvMi8=cGRmd2l0aEFsZXJ0LnBkZg==

[prakashsvmx]

@cesnietor , Thank you, i have now updated , and also the tests related to back end changes.

[allanrogerr]

@prakashsvmx Please check Vulnerability #1: GO-2023-2382

[allanrogerr]

Tested

[cesnietor]

tested LGTM