-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail request when error occurs during download #3214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -143,7 +146,7 @@ export const download = ( | |||
return; | |||
} | |||
} | |||
errorCallback(`Unexpected response status code (${req.status}).`); | |||
errorCallback(`Unexpected response, download incomplete.`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the status code does not help debugging, can we try to add more information here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status by itself was also not very helpful. You'll need to see the logs for now. We were not exposing the errors before either.
Exposing detailed errors is in our backlog.
fixes: #3006
Checks whether the download was complete in the frontend.
In the backend, setting the headers doesn't work if it fails during io.Copy cause it already starterd writing to the body. So we just log it and handle it in the client layer.
On error:

After:
Test Steps:
/// Other tests