-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Console as proxy for share object logic #3284
Use Console as proxy for share object logic #3284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Tested in local env as well as making a custom MinIO build with this fix.
@cesnietor , Do we still need to limit the number of hours as in the screenshot? Also the subpath based console ui seems to show the minio server url . is this fine? |
@prakashsvmx yes we still need to do the hour limitation since the url is signed with that expiration.
@prakashsvmx it's fine if the new url is using the subpath. Or do you mean the encoded minIO url is using the subpath? could you please give me an example? or what do you mean? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes: #3255
Share File URL now points to Console to facilitate sharing the url in case MinIO endpoint is not exposed.
Changes:
How it looks:
When url expired:
Test steps:
With an existing bucket, folder and objects.