Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Drives list UI #3395

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Improvements to Drives list UI #3395

merged 3 commits into from
Jul 1, 2024

Conversation

bayasdev
Copy link
Contributor

@bayasdev bayasdev commented Jul 1, 2024 •
edited
Loading

Fixes #3376

Overview

  • Show used and available space percentages
  • Implemented new design

How does it look

Screenshot 2024-07-01 at 5 37 48 PM Screenshot 2024-07-01 at 5 38 40 PM

@bayasdev bayasdev added the enhancement New feature or request label Jul 1, 2024
@bayasdev bayasdev self-assigned this Jul 1, 2024
@bayasdev bayasdev force-pushed the drives-list-improvements branch from ba80feb to 931e427 Compare July 1, 2024 22:43
oscarocastellanos
oscarocastellanos previously requested changes Jul 1, 2024
View reviewed changes
Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @bayasdev ! Can we change the text inside the graphs to say "Total Capacity"? Also, the total capacity label inside the graphs should live above the number. Thanks!

@bayasdev bayasdev force-pushed the drives-list-improvements branch from 931e427 to 08f3acf Compare July 1, 2024 22:45
@bayasdev
Copy link
Contributor Author

bayasdev commented Jul 1, 2024

This looks great @bayasdev ! Can we change the text inside the graphs to say "Total Capacity"? Also, the total capacity label inside the graphs should live above the number. Thanks!

Thanks @oscarocastellanos! Currently we don't support showing the total capacity as the inner label of the SizeChart component.

CC @sen-io @bexsoft

sen-io
sen-io previously approved these changes Jul 1, 2024
View reviewed changes
@bayasdev bayasdev requested a review from sen-io July 1, 2024 23:01
@oscarocastellanos
Copy link

This looks great @bayasdev ! Can we change the text inside the graphs to say "Total Capacity"? Also, the total capacity label inside the graphs should live above the number. Thanks!

Thanks @oscarocastellanos! Currently we don't support showing the total capacity as the inner label of the SizeChart component.

CC @sen-io @bexsoft

I understand! It would be ideal to support this in the future, as this is something crucial for the experience on understanding the information. All good otherwise 👍🏼

@bexsoft
Copy link
Collaborator

bexsoft commented Jul 1, 2024

This looks great @bayasdev ! Can we change the text inside the graphs to say "Total Capacity"? Also, the total capacity label inside the graphs should live above the number. Thanks!

Thanks @oscarocastellanos! Currently we don't support showing the total capacity as the inner label of the SizeChart component.
CC @sen-io @bexsoft

I understand! It would be ideal to support this in the future, as this is something crucial for the experience on understanding the information. All good otherwise 👍🏼

Yes @oscarocastellanos, this change must be done in mds

@bexsoft bexsoft dismissed oscarocastellanos’s stale review July 1, 2024 23:27

Change to be done in mds

@bexsoft bexsoft merged commit 69fad3f into minio:master Jul 1, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesnietor cesnietor cesnietor approved these changes

@bexsoft bexsoft bexsoft approved these changes

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@ramondeklein ramondeklein Awaiting requested review from ramondeklein

@cniackz cniackz Awaiting requested review from cniackz

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@adriangitvitz adriangitvitz Awaiting requested review from adriangitvitz

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@dilverse dilverse Awaiting requested review from dilverse

@oscarocastellanos oscarocastellanos Awaiting requested review from oscarocastellanos

@sen-io sen-io Awaiting requested review from sen-io

Assignees

@bayasdev bayasdev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature]: show drive usage percentage in web-UI
5 participants
@bayasdev @oscarocastellanos @bexsoft @cesnietor @sen-io