Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sanitize file path while drag and drop #3492

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Jan 13, 2025

fix sanitize file path while drag and drop

In chrome, when files are dragged and dropped it adds ./ to the path. it makes the uploads fail.

this fix sanitizes the path so the uploads will go through.

Tested in Linux :
Chrome,
Firefox.
IE Edge

Bug:
console_dnd_upload_bug.webm

Fix:
console_dnd_upload_fix.webm

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 4388ecc into minio:master Jan 14, 2025
28 of 30 checks passed
@cesnietor
Copy link
Collaborator

cesnietor commented Feb 6, 2025

@prakashsvmx tested this and it breaks Chrome.
It doesn't happen in safari but I get this in chrome.
While Drag and Dropping an object with latest minio b8dde47d4e8d0d26c583f8ea106633c6c140f3f9
Screenshot 2025-02-06 at 2 01 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants