Implemented User-Groups integration for mcs #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
reviewed
Apr 9, 2020
cesnietor
reviewed
Apr 9, 2020
dvaldivia
previously approved these changes
Apr 9, 2020
cesnietor
reviewed
Apr 9, 2020
restapi/admin_users.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| userElem := &models.User{ | ||
| AccessKey: *accessKey, | ||
| userElem, errUG := updateUserGroups(ctx, client, *accessKey, groups) |
There was a problem hiding this comment.
we should probably just call this function if groups is not empty, else all the code inside will be run .
Implemented user-groups integration for mcs, this allows to store the user groups during the user creation.
dvaldivia
approved these changes
Apr 9, 2020
cesnietor
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR connects the add user-groups API to the add user modal box
How to Test