Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of reusable components for mcs & implementation in users page #63

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Creation of reusable components for mcs & implementation in users page #63

merged 1 commit into from
Apr 11, 2020

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Apr 11, 2020

What does this do?

Creation of reusable componentes for mcs:

  • ModalWrapper => Modal box component with MinIO styles
  • InputBoxWrapper => Input box component with MinIO styles
  • RadioGroupSelector => Component that generates a Radio Group Selector combo with the requested options and MinIO styles

Implementation of these new components in users creation / edit components

How it looks

Screen Shot 2020-04-10 at 10 12 18 PM
Screen Shot 2020-04-10 at 10 12 02 PM

How to test?

  • Go into User page and try to add a new user
  • Look at the components specially in modal box & input boxes
  • Add the user and check that everything works as usual
  • Select the user that you've just added and click on the view button
  • In the opened modal you should see the radio combo component implemented
  • Change the status of the user as well as change the groups for it
  • Click on save, The changes must be saved
  • Refresh the page & click on the edit button for the modified user again
  • You should see the saved information.

@bexsoft bexsoft self-assigned this Apr 11, 2020
dvaldivia
dvaldivia previously approved these changes Apr 11, 2020
Creation of reusable componentes for mcs:
- ModalWrapper => Modal box component with MinIO styles
- InputBoxWrapper => Input box component with MinIO styles
- RadioGroupSelector => Component that generates a Radio Group Selector combo with the requested options and MinIO styles

Implementation of these new components in users creation / edit components
@bexsoft bexsoft requested a review from dvaldivia April 11, 2020 03:44
@dvaldivia dvaldivia merged commit 1b1ed55 into minio:master Apr 11, 2020
@bexsoft bexsoft deleted the user-edit-modal branch April 14, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants