fix name/url/email etc fields in operator bundle #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
requested review from
balamurugana,
harshavardhana and
Praveenrajmani
harshavardhana
requested changes
Sep 6, 2023
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
|
Done @harshavardhana changes committed, now waiting for tests to pass!. Thanks for the review 👍 |
balamurugana
requested changes
Sep 7, 2023
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
Praveenrajmani
previously approved these changes
Sep 12, 2023
helm/bundle/manifests/minio-directpv-operator-rhmp.clusterserviceversion.yaml
Show resolved
Hide resolved
Praveenrajmani
previously approved these changes
Sep 12, 2023
balamurugana
approved these changes
Sep 13, 2023
balamurugana
changed the title
harshavardhana
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To have just one CSV after renaming the package name in previous PR:
fix package name in operator bundle generation
To fix:
$ operator-sdk bundle validate ./bundle FATA[0000] [error loading objs in directory: invalid bundle: contains multiple CSVs, no bundle csv found, unable to load bundle from directory bundle/manifests]