Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OpenShift Supported version after generating the bundle #847

Merged

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Sep 16, 2023

Objective:

To add OpenShift Supported Versions.

Associated PRs:

Current Error:

[get-supported-versions : supported-version-check] ++ cat config.yaml
[get-supported-versions : supported-version-check] ++ yq -r .organization
[get-supported-versions : supported-version-check] + ORGANIZATION=redhat-marketplace
[get-supported-versions : supported-version-check] + OCP_VERSIONS_OUTPUT_FILE=./ocp_versions.json
[get-supported-versions : supported-version-check] + ocp-version-info --output-file ./ocp_versions.json operators/minio-directpv-operator-rhmp/4.0.7 redhat-marketplace
[get-supported-versions : supported-version-check] Traceback (most recent call last):
[get-supported-versions : supported-version-check]   File "/home/user/.venv/bin/ocp-version-info", line 8, in <module>
[get-supported-versions : supported-version-check]     sys.exit(main())
[get-supported-versions : supported-version-check]              ^^^^^^
[get-supported-versions : supported-version-check]   File "/home/user/.venv/lib/python3.11/site-packages/operatorcert/entrypoints/ocp_version_info.py", line 44, in main
[get-supported-versions : supported-version-check]     version_info = ocp_version_info(bundle_path, args.pyxis_url, args.organization)
[get-supported-versions : supported-version-check]                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[get-supported-versions : supported-version-check]   File "/home/user/.venv/lib/python3.11/site-packages/operatorcert/__init__.py", line 176, in ocp_version_info
[get-supported-versions : supported-version-check]     raise ValueError(f"'{OCP_VERSIONS_ANNOTATION}' annotation not defined")
[get-supported-versions : supported-version-check] ValueError: 'com.redhat.openshift.versions' annotation not defined

Solution:

  • To add missing annotation but setting overwrite to false so that we keep them.

Examples:

  • In our MinIO Operator we do same:

https://github.com/redhat-openshift-ecosystem/redhat-marketplace-operators/blob/main/operators/minio-operator-rhmp/5.0.9/metadata/annotations.yaml#L8C1-L9C44

@cniackz cniackz self-assigned this Sep 16, 2023
@cniackz cniackz added the certification for any given certification label Sep 16, 2023
@harshavardhana harshavardhana merged commit 64ca50d into minio:master Sep 18, 2023
22 checks passed
@cniackz
Copy link
Contributor Author

cniackz commented Sep 18, 2023

Thank you @harshavardhana 👍

@cniackz cniackz deleted the set-openshift-supported-version-2 branch September 18, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
certification for any given certification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants