Split device sync into readable functions #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bala.FA <bala@minio.io>
balamurugana
force-pushed
the
Split-device-sync-into-readable-functions
branch
from
c8f0f2c to
93783b6
Compare
| drive.Spec.Relabel = false | ||
| } | ||
|
|
||
| return true |
There was a problem hiding this comment.
shouldn't we return the updated var instead? and we can set this var to true whenever the drive fields are updated. There are cases where we don't need the drive update.
There was a problem hiding this comment.
In error case and success case, we should set updated = true. This means we are returning true in any case. That's why return true is correct.
| } | ||
|
|
||
| if err == nil { | ||
| drive.Spec.Relabel = false |
There was a problem hiding this comment.
can we set updated = true here and return at the end?
| default: | ||
| if latestErrorConditionType != directpvtypes.DriveConditionTypeIOError { | ||
| drive.Status.Status = directpvtypes.DriveStatusError | ||
| drive.SetRelabelErrorCondition(fmt.Sprintf("unable to relabel; %v", err)) |
There was a problem hiding this comment.
can we set updated = true here and return at the end?
Praveenrajmani
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.