Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomize support for declarative management #952

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Praveenrajmani
Copy link
Collaborator

No description provided.

resources/kustomization.yaml Outdated Show resolved Hide resolved
resources/kustomization.yaml Outdated Show resolved Hide resolved
resources/legacy/base/CSIDriver-direct-csi-min-io.yaml Outdated Show resolved Hide resolved
resources/openshift/base/CSIDriver.yaml Outdated Show resolved Hide resolved
@Praveenrajmani Praveenrajmani force-pushed the add_kustomize branch 6 times, most recently from e6e23fc to d7a5dc0 Compare September 27, 2024 13:06
@Praveenrajmani Praveenrajmani force-pushed the add_kustomize branch 5 times, most recently from 4e65d71 to c64ad0b Compare October 2, 2024 08:03
Copy link
Member

@pjuarezd pjuarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed a small thing in RBAC, maybe the same comments apply to the ClusterRole.yaml in the helm chart operator/helm-charts/directpv-chart/templates/ClusterRole.yaml

resources/base/ClusterRole.yaml Outdated Show resolved Hide resolved
resources/base/ClusterRole.yaml Outdated Show resolved Hide resolved
resources/base/ClusterRole.yaml Outdated Show resolved Hide resolved
Copy link
Member

@pjuarezd pjuarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more comments on RBAC

@balamurugana balamurugana changed the title Add manifests for kustomize Add kustomize support for declarative management Oct 3, 2024
@Praveenrajmani Praveenrajmani merged commit 3a1e26f into minio:master Oct 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants