Configure replicas #957
Open
Configure replicas #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's against the Helm best practices to create a Namespace with a chart template. It particularly breaks installing it with FluxCD as a HelmRelease. See helm/helm#5465 (comment) for the explanation.
balamurugana
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Use https://github.com/minio/directpv/tree/master/resources instead of unmaintained helm and we don't have plans to keep it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR makes the controller replicas configurable.
It also:
values.yamlNamespace.yamlto match Helm best practices (see Best Practices/Docs Question - Specify Namespace in Chart? helm/helm#5465 (comment) for the explanation)