-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-1007: Create sync pattern to pull in the CRD during releases #1025
Conversation
I'm kinda fuzzy about the process. Asciidoc docs say it's a markup language, not a software package, and install asciidoctor instead. So:
But this installs:
It did something, at least
|
Links don't do anything, there are supposed to be anchors in the page?
url
|
OK the SED issue I think I know is because of a difference between gnu and bash As far as the links...those are probably irrevocably broken. Maybe. I might be able to wildcard-sed through them though. Will take a shot. |
👍🏻 Lemme know when you want another test |
I'll have to poke this for a bit - probably tomorrow or early next week. |
Were the links expected to work this time, or no? I'm not getting the |
Similar to Andrea, I'm getting the following:
|
OK - I get the same warnings, and as I can tell it doesn't break the build. I'm also not sure where it's originating from or how to fix them. They might be stuff we have to live with - if it's annoying I'll see if there's a way to suppress the output. |
@feorlen I think that's actually a CSS issue - it's |
That particular example, the second column is blank for all three rows. All of the problem lines are the table closings lines. But it's only on certain tables. I'm seeing if I can figure out what the parser is having issues with. |
Oh, duh, the header row is, in fact, problematic. The parser is having issues with any table that has one or more blank cells. |
Update the README, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Summary
Closes #1007
Staged: http://192.241.195.202:9000/staging/DOCS-1007/k8s/reference/operator-crd.html
This PR is a bit of an automation trick for us to lean on. Effectively it adds one new Makefile command we can run at any time.
It pulls down the https://github.com/minio/operator/blob/v5.0.9/docs/tenant_crd.adoc using the latest available release tag, processes it through a combination of asciidoc and pandoc, and then does some sed magic to clean up the TOC to be more navigable.
This requires installation of asciidoc and pandoc to run. It will, for now, be a manual process we run when Operator releases get generated. It should simply overwrite the
includes/k8s/ext-tentant-crd.md
file with the newly updated content.How to test
Install asciidoc and pandoc
Run
make sync-operator-crd
It should work
Not in scope
Styling the tables - although interestingly this markdown table does breaks on long monospaced texts. @rushenn if you can see what style trick is applied here, and if we apply that to other tables in general, it might fix a bit of a css pain point we've had.