Breaking up envvars and config settings into separate settings pages #1028
Conversation
source/reference/minio-server/settings/notifications/webhook-service.rst
Outdated
Show resolved
Hide resolved
|
The TOC order feels a bit arbitrary? As in, I would expect things like core and root near the top and additional at the end. (The ordering in the original page wasn't wonderful, to be sure.) Maybe something like (or thereabouts) |
|
|
||
| Configuration Settings | ||
| ---------------------- | ||
|
|
There was a problem hiding this comment.
Maybe something here that links to mc admin config? If you randomly showed up on this page it's a pointer to how they are used.
|
Hm. So Open Question ™️ on the structure. Right now it's: I would actually suggestoin That way all of the possible settings for a given Thing are in one scrollable H1. Thoughts? |
|
|
||
| *Optional* | ||
|
|
||
| Enable parallel workers by specifying the maximum number of processes to use when performing the batch application job. |
There was a problem hiding this comment.
I believe the workers are always parallel. This just sets the number of workers.
@poornas do we have guidance here on how to set it, or what the defaults are?
There was a problem hiding this comment.
Updated the description, but can add defaults or other recommendations if we have any.
There was a problem hiding this comment.
batch workers can be set with _MINIO_BATCH_REPLICATION_WORKERS - it defaults to max cpus/2
| Settings | ||
| -------- | ||
|
|
||
| Enable |
There was a problem hiding this comment.
Hm. I'm guessing we have to do it this way to avoid the duplication of text the entire way down for each tab item?
There was a problem hiding this comment.
That is having an H2 for every single setting
There was a problem hiding this comment.
Also provides nice in-page navigation (on the right toc) to jump to a specific setting.
|
|
||
| ``access`` | ||
| For each bucket event, MinIO creates a JSON document with the event details and appends it to the key with a Redis-generated random ID. | ||
| Additional updates to an object result in new index entries, and existing entries remain unmodified. |
There was a problem hiding this comment.
| Additional updates to an object result in new index entries, and existing entries remain unmodified. | |
| Additional updates to an object result in new index entries, and existing entries remain unmodified. |
There was a problem hiding this comment.
Noted a few items to look at, along with a bunch of opportunistic fixes to the original text. This is a huge undertaking and already looks so much better.
I think your idea to use an include for the nothing to see here tab text would make future-writer very happy. Yay.
Corrects errors from `mc-conf` references not noticed until after merging #1028 . No issue to track it.
Creates a slew of folders and pages nested under the mc-server page to store settings.
Breaks up all of the environment variable options formerly in the mc-server page into these separate pages.
Moves the config settings formerly in the mc admin config page to the appropriate new settings pages.
Closes #1017
Staged:
http://192.241.195.202:9000/staging/server-breakup/linux/reference/minio-server/settings.html