-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-1021: Adding helm information #1060
Conversation
source/operations/install-deploy-manage/deploy-operator-helm.rst
Outdated
Show resolved
Hide resolved
source/operations/install-deploy-manage/upgrade-minio-operator.rst
Outdated
Show resolved
Hide resolved
@mjminio I can't add you as a reviewer until you're in the MinIO member org, but I can tag you to take a look! |
Co-authored-by: Andrea Longo <feorlen@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
On this sentence
I am not sure the flag
I think the flag is (sorry for close the PR, fat finger clicked the wrong button) |
Thought I caught all these - it should be -S, not -c. minio server --help
NAME:
minio server - start object storage server
...
--certs-dir value, -S value path to certs directory (default: "/home/ravindkminio/.minio/certs")
@pjuarezd fixed. |
source/operations/install-deploy-manage/deploy-operator-helm.rst
Outdated
Show resolved
Hide resolved
source/operations/install-deploy-manage/deploy-minio-tenant-helm.rst
Outdated
Show resolved
Hide resolved
source/operations/install-deploy-manage/deploy-minio-tenant-helm.rst
Outdated
Show resolved
Hide resolved
source/operations/install-deploy-manage/deploy-minio-tenant-helm.rst
Outdated
Show resolved
Hide resolved
source/operations/install-deploy-manage/deploy-minio-tenant-helm.rst
Outdated
Show resolved
Hide resolved
source/operations/install-deploy-manage/deploy-minio-tenant-helm.rst
Outdated
Show resolved
Hide resolved
source/operations/install-deploy-manage/deploy-minio-tenant-helm.rst
Outdated
Show resolved
Hide resolved
source/operations/install-deploy-manage/deploy-minio-tenant-helm.rst
Outdated
Show resolved
Hide resolved
source/operations/install-deploy-manage/deploy-operator-helm.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Pedro Juarez <pjuarezd@users.noreply.github.com>
Co-authored-by: Pedro Juarez <pjuarezd@users.noreply.github.com>
@pjuarezd staging updated. Thank you for your review! |
All of this is awesome! It's really going to make the difference with the helm chart users, thank you @ravindk89 @feorlen |
minio/operator#1827 once this closes I'll complete the work on this. DO NOT MERGE THIS PR YET! |
Closes #1021
Closes #1055
Closes #968
Closes #943
This is technically dependent on minio/operator#1827 merging to complete the automation.
As a final pass, the
values.yaml
files will be removed, gitignored, and pulled in dynamically at build-time.Summary
Two main goals here:
values.yaml
for use with Sphinx Autoyaml so we have a web-based docs to reference hereOut of Scope
A larger treatment of Helm, including creating more subpages and removing some of the overloaded upgrade sections for Operator - that requires some careful rearchitecture I cannot quite wrap my head around right now
Staged
Linux:
K8s: