-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for two October releases #1065
Conversation
|
||
MinIO supports three types of :kube-docs:`secrets in Kubernetes <concepts/configuration/secret/#secret-types>`. | ||
|
||
#. opaque |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are opaque and tls here keywords, of a sort that might get inline code
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are specific types in the linked K8s docs list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod clarity on how much we can imply about support prior to 5.0.10
|
||
Running on Kubernetes 1.21 or later. | ||
|
||
For the best support of *tls* or *cert-manager* secrets, upgrade to Operator version 5.0.10 or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cesnietor if support for these two types are effectively broken pre 5.0.10, should we just say "support added" and go that way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @cniackz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry Cesar! Stupid github autoselect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @ravindk89, currently, cert-manager can function as expected when we provide the specified name for the certificate. Additionally, there is a pending PR that, once merged, will prevent the unnecessary request for this secret to be mounted. Therefore, I anticipate no issues after version 5.0.10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok PR got merged already: https://github.com/minio/operator/pull/1847/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending Eng input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @ravind. We should simply mention 'support added' without specifying any particular version, as that information would likely become outdated soon. Apart from that, the PR appears satisfactory to me.
mc admin trace
Closes #1039
Staged:
For the
mc admin trace --stats
flag, also adding example output.Closes #1045