Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for two Oct 2023 mc releases #1066

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Updates for two Oct 2023 mc releases #1066

merged 4 commits into from
Nov 10, 2023

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented Nov 9, 2023

Updates for October 2023 MinIO Client releases

  • Adds output sample for mc support top locks
  • Adds mc idp ldap accesskey and subcommands

Closes #1056

  • Adds environment variables for most global flags
  • Adds --retry flag to mc mirror
  • Adds --bucket-bandwidth flag to mc admin replicate update

Partially addresses #1045

  • Removes unsupported --noncurrent-transition-newer flags from commands.

Staged:
http://192.241.195.202:9000/staging/mc-oct-2023/linux/reference/minio-mc.html

djwfyi added 2 commits November 9, 2023 12:18
@djwfyi
Updates for October 2023 MinIO Client releases
e0d5618 
- Adds output sample for `mc support top locks`
- Adds `mc idp ldap accesskey` and subcommands

Closes #1056

- Adds environment variables for most global flags
- Adds --retry flag to mc mirror
- Adds --bucket-bandwidth flag to mc admin replicate update

Partially addresses #1045
@djwfyi
Correcting build errors
f207612
@djwfyi djwfyi requested review from feorlen and ravindk89 November 9, 2023 17:33
@djwfyi djwfyi self-assigned this Nov 9, 2023
ravindk89
ravindk89 requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to tighten up, but otherwise solid

source/reference/minio-mc/mc-idp-ldap-accesskey-info.rst Show resolved Hide resolved
source/reference/minio-mc/mc-idp-ldap-accesskey-ls.rst Outdated Show resolved Hide resolved
source/reference/minio-mc/mc-idp-ldap-accesskey.rst Show resolved Hide resolved
@feorlen
Copy link
Collaborator

feorlen commented Nov 9, 2023

Maybe this is answered elsewhere that I didn't find: --noncurrent-transition-newer being unsupported means "never did that" as opposed to deprecated. Correct?

@djwfyi
Copy link
Collaborator Author

djwfyi commented Nov 9, 2023

Maybe this is answered elsewhere that I didn't find: --noncurrent-transition-newer being unsupported means "never did that" as opposed to deprecated. Correct?

Yes, this was a discussion on an internal Slack channel. The never did that is true in this case. This does not need to move to deprecated, just be removed entirely.

@djwfyi djwfyi merged commit abee6a3 into main Nov 10, 2023
@djwfyi djwfyi deleted the mc-oct-2023 branch November 10, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taran-p taran-p taran-p left review comments

@ravindk89 ravindk89 ravindk89 approved these changes

@feorlen feorlen Awaiting requested review from feorlen

Assignees

@djwfyi djwfyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RELEASE] mc RELEASE.2023-10-30T18-43-32Z
4 participants
@djwfyi @feorlen @ravindk89 @taran-p