-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to remove plugin from docs #1219
Merged
Merged
Changes from 26 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
8b32cc1
partial update
feorlen a7a2bc4
remove plugin page from nav
feorlen 2d1fd9a
move kustomize content to deploy operator page
feorlen d79d9f2
attempt to remove plugin references, replace with what?
feorlen 72ef474
move older upgrade instructions to new page
feorlen b95ca0b
yeet plugin content, needs new kustomize alternatives
feorlen a07fac8
update upgrade tenant
feorlen 3ec4723
update expand tenant - needs kustomize instructions
feorlen 0057c02
update delete tenant -- needs kustomize instructions
feorlen 62199be
update upgrade operator - needs kustomize instructions
feorlen 9d0b3b8
update openshift - needs ?
feorlen a96691f
update plugin dl url to 5.0.14, latest available
feorlen dd9eb77
update aks/gke/eks - needs kustomize
feorlen edc2c95
update iam/sse
feorlen c740edb
remove plugin proxy mention - needs ?
feorlen 9d00643
remove plugin pages, except init
feorlen 523d592
clean up ugly merge
feorlen f15f328
Start adding non-plugin steps for Operator deploy/upgrade and Tenant …
feorlen 3f58ef9
Operator deploy/upgrade, Tenant deploy tested
feorlen ffa06d2
upgrade tenant kubectl instructions
feorlen 662ee53
update expand tenant
feorlen 2471184
update delete tenant
feorlen b383a1c
spellcheck
feorlen c639e63
fixup
feorlen 2aa4a98
Merge branch 'main' into DOCS-1213-upstream
feorlen 8071eba
partial update from review feedback
feorlen 498b273
more feedback updates
feorlen 03b9d96
might revert later: same k8s operator include for aks,eks,gke procedure
feorlen 66f5dd0
Different steps for tenant originally deployed with Operator Console …
feorlen 61efe45
fix references to plugin for port forwarding
feorlen 53ee6bd
hide ancient screenshots pending new ones
feorlen 9194895
Merge branch 'main' into DOCS-1213-upstream
feorlen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 0 additions & 81 deletions
81
source/includes/common/common-install-operator-kubectl-plugin.rst
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
source/includes/common/common-k8s-connect-operator-console-no-plugin.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
The Operator Console service does not automatically bind or expose itself for external access on the Kubernetes cluster. | ||
You must instead configure a network control plane component, such as a load balancer or ingress, to grant that external access. | ||
feorlen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. cond:: k8s | ||
|
||
For testing purposes or short-term access, expose the Operator Console service through a NodePort using the following patch: | ||
|
||
.. code-block:: shell | ||
:class: copyable | ||
|
||
kubectl patch service -n minio-operator console -p ' | ||
{ | ||
"spec": { | ||
"ports": [ | ||
{ | ||
"name": "http", | ||
"port": 9090, | ||
"protocol": "TCP", | ||
"targetPort": 9090, | ||
"nodePort": 30090 | ||
}, | ||
{ | ||
"name": "https", | ||
"port": 9443, | ||
"protocol": "TCP", | ||
"targetPort": 9443, | ||
"nodePort": 30433 | ||
} | ||
], | ||
"type": "NodePort" | ||
} | ||
}' | ||
|
||
You can now access the service through port ``30433`` on any of your Kubernetes worker nodes. | ||
feorlen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Append the ``nodePort`` value to the externally-accessible IP address of a worker node in your Kubernetes cluster. | ||
Use the appropriate ``http`` or ``https`` port depending on whether you deployed Operator Console with TLS. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah.
FWIW the procedure should be exactly identical no matter what. EKS, AKS, and GKS should treat
kubectl apply -k github.com/minio/operator
identically.I can also handle this as part of the deplatformization if we want, but if we go that route we have to push this to an independent branch before we go to main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying something - same text from k8s (conveniently already an include) as the "Procedure" section for aks, eks, gke.
I'm not entirely sure the console port forwarding instructions are accurate for not-k8s. Also the admonition about only using Kustomize going forward. I could also copy the include content, minus those bits, into the three other pages.
Or is it close enough, given it's all getting yeeted shortly anyway.
Thoughts? @ravindk89 @djwfyi
staged:
aks:
http://192.241.195.202:9000/staging/DOCS-1213-upstream/aks/operations/installation.html#procedure
eks:
http://192.241.195.202:9000/staging/DOCS-1213-upstream/eks/operations/installation.html#procedure
gke:
http://192.241.195.202:9000/staging/DOCS-1213-upstream/gke/operations/installation.html#procedure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this is good enough.