Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC updates for two releases. #1382

Merged
merged 2 commits into from
Dec 6, 2024
Merged

MC updates for two releases. #1382

merged 2 commits into from
Dec 6, 2024

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented Dec 5, 2024

  • Adds mc support top rpc command
  • Adds information about new mc support inspect file names

Closes #1361

  • Updates healing color meaning.

Closes #1371

Staging Info:

- Adds mc support top rpc command
- Adds information about new mc support inspect file names

Closes #1361

- Updates healing color meaning.

Closes #1371
@djwfyi djwfyi self-assigned this Dec 5, 2024
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, mostly cleanup and not blockers.

source/reference/minio-mc-admin/mc-admin-heal.rst Outdated Show resolved Hide resolved
source/reference/minio-mc/mc-support-top-rpc.rst Outdated Show resolved Hide resolved
@djwfyi djwfyi requested review from ravindk89 and feorlen December 6, 2024 16:32
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod nit

:optional:

Replay a previously saved JSON file.
Specify the path to the JSON file to replay, such as one generated by a previous run of this command.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll needle a bit more - does it always output a JSON file, or do you have to pipe the output?

Copy link
Collaborator

@Bradamant3 Bradamant3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm although I wasn't one of the original requesters-of-changes. Also cannot miss this opportunity to lament accessibility issue of use of color. At least it's less around (and yes I realize this is not an issue for docs to fix ...)

@djwfyi djwfyi merged commit 5006f1f into main Dec 6, 2024
1 check passed
@djwfyi djwfyi deleted the mc-updates branch December 6, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RELEASE] MC RELEASE.2024-11-17T19-35-25Z [RELEASE] MinIO Client RELEASE.2024-10-29T15-34-59Z
4 participants