-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MC updates for two releases. #1382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, mostly cleanup and not blockers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod nit
:optional: | ||
|
||
Replay a previously saved JSON file. | ||
Specify the path to the JSON file to replay, such as one generated by a previous run of this command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll needle a bit more - does it always output a JSON file, or do you have to pipe the output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm although I wasn't one of the original requesters-of-changes. Also cannot miss this opportunity to lament accessibility issue of use of color. At least it's less around (and yes I realize this is not an issue for docs to fix ...)
Closes #1361
Closes #1371
Staging Info: