Migrate from "mime" to "github.com/minio/minio/pkg/mimedb"

The content-type resolutions are standardized across platforms.

Fixes #2559

cmd/client-s3.go

@@ -23,7 +23,6 @@ import (
 	"encoding/json"
 	"hash/fnv"
 	"io"
-	"mime"
 	"net"
 	"net/http"
 	"net/url"
@@ -42,6 +41,7 @@ import (
 	"github.com/minio/minio-go/pkg/encrypt"
 	"github.com/minio/minio-go/pkg/policy"
 	"github.com/minio/minio-go/pkg/s3utils"
+	"github.com/minio/minio/pkg/mimedb"
 )
 
 // S3 client
@@ -396,8 +396,8 @@ var supportedContentTypes = []string{
 
 func (c *s3Client) Select(expression, sseKey string) (io.ReadCloser, *probe.Error) {
 	bucket, object := c.url2BucketAndObject()
-	origContentType := mime.TypeByExtension(filepath.Ext(strings.TrimSuffix(strings.TrimSuffix(object, ".gz"), ".bz2")))
-	contentType := mime.TypeByExtension(filepath.Ext(object))
+	origContentType := mimedb.TypeByExtension(filepath.Ext(strings.TrimSuffix(strings.TrimSuffix(object, ".gz"), ".bz2")))
+	contentType := mimedb.TypeByExtension(filepath.Ext(object))
 	opts := minio.SelectObjectOptions{
 		Expression:     expression,
 		ExpressionType: minio.QueryExpressionTypeSQL,

cmd/client-url.go

@@ -18,13 +18,13 @@ package cmd
 
 import (
 	"bytes"
-	"mime"
 	"path/filepath"
 	"regexp"
 	"runtime"
 	"strings"
 
 	"github.com/minio/mc/pkg/probe"
+	"github.com/minio/minio/pkg/mimedb"
 )
 
 // url client url structure
@@ -228,9 +228,6 @@ func isURLPrefixExists(urlPrefix string, incomplete bool) bool {
 // on failure just return 'application/octet-stream'.
 func guessURLContentType(urlStr string) string {
 	url := newClientURL(urlStr)
-	contentType := mime.TypeByExtension(filepath.Ext(url.Path))
-	if contentType == "" {
-		contentType = "application/octet-stream"
-	}
+	contentType := mimedb.TypeByExtension(filepath.Ext(url.Path))
 	return contentType
 }

cmd/select-main.go

@@ -18,13 +18,13 @@ package cmd
 
 import (
 	"io"
-	"mime"
 	"os"
 	"path/filepath"
 	"strings"
 
 	"github.com/minio/cli"
 	"github.com/minio/mc/pkg/probe"
+	"github.com/minio/minio/pkg/mimedb"
 )
 
 var (
@@ -130,7 +130,7 @@ func mainSelect(ctx *cli.Context) error {
 				errorIf(content.Err.Trace(url), "Unable to list on target `"+url+"`.")
 				continue
 			}
-			contentType := mime.TypeByExtension(filepath.Ext(content.URL.Path))
+			contentType := mimedb.TypeByExtension(filepath.Ext(content.URL.Path))
 			for _, cTypeSuffix := range supportedContentTypes {
 				if strings.Contains(contentType, cTypeSuffix) {
 					errorIf(selectQl(targetAlias+content.URL.Path, ctx.String("expression"),