mc heal and mc mirror should respond with proper exit code (#2543)

respond with os.exit(0) incase of errors Fixes #2534 #2474
minio · Sep 20, 2018 · b2d2e09 · b2d2e09
1 parent c9f3369
commit b2d2e09
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/cmd/admin-heal.go b/cmd/admin-heal.go
@@ -131,5 +131,5 @@ func mainAdminHeal(ctx *cli.Context) error {
 		"Unable to display follow heal status.",
 	)
 
-	return nil
+	return herr
 }
diff --git a/cmd/typed-errors.go b/cmd/typed-errors.go
@@ -96,11 +96,13 @@ var errInvalidTarget = func(URL string) *probe.Error {
 	return probe.NewError(invalidTargetErr(errors.New(msg))).Untrace()
 }
 
-type overwriteNotAllowedErr error
+type overwriteNotAllowedErr struct {
+	error
+}
 
 var errOverWriteNotAllowed = func(URL string) *probe.Error {
 	msg := "Overwrite not allowed for `" + URL + "`. Use `--overwrite` to override this behavior."
-	return probe.NewError(overwriteNotAllowedErr(errors.New(msg)))
+	return probe.NewError(overwriteNotAllowedErr{errors.New(msg)})
 }
 
 type sourceIsDirErr error