Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify admin policy command #4272

Closed
kannappanr opened this issue Sep 28, 2022 · 6 comments · Fixed by #4428
Closed

Modify admin policy command #4272

kannappanr opened this issue Sep 28, 2022 · 6 comments · Fixed by #4428
Assignees

Comments

@kannappanr
Copy link
Collaborator

Change the add sub-command to create

Output of mc admin policy --help will be as follows.

create     create a new IAM policy
list          list all IAM policies
info        show info on an IAM policy
remove  remove an IAM policy

Also, add examples to create a policy and assign it to a user/group in the help of mc admin policy create

Also, set, unset and upate sub-commands will be removed and moved under mc admin user policy and mc admin group policy commands

@dormanze
Copy link
Contributor

May I fix this issue?

@taran-p
Copy link
Contributor

taran-p commented Sep 29, 2022

@dormanze I will be fixing the issue

@sathieu
Copy link

sathieu commented Apr 3, 2023

While I understand cleaning up the CLI, why are you removing the old command at the same time?

@wobrycki
Copy link

We also have problems migrating to the newest syntax after breaking changes were inroduced.
The old syntax is not available anymore, and other ongoing issues related to the new syntax, have not been resolved yet:
aminueza/terraform-provider-minio#116 This 'admin' API is not supported by server in 'mode-server-fs
With the old syntax working, we probably still would have a working mc admin policy, now we have to go through a time-consuming downgrading process.

Example:
old one mc admin policy set data_lake_connection $MINIO_USER user=$MINIO_USER was working
new one mc admin policy attach data_lake_connection $MINIO_USER --user=$MINIO_USER does not work and throws This 'admin' API is not supported by server in 'mode-server-fs'.
FYI @taran-p

@harshavardhana
Copy link
Member

new one mc admin policy attach data_lake_connection $MINIO_USER --user=$MINIO_USER does not work and throws This 'admin' API is not supported by server in 'mode-server-fs'.

You are on legacy deployment @wobrycki you need to migrate away from FS mode. To use the newer mc you need to upgrade your server as well or stick to the older version that works and do not need to use the newer mc with the older server.

@harshavardhana
Copy link
Member

While I understand cleaning up the CLI, why are you removing the old command at the same time?

Because we want you to start changing your scripts to match the new requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants