Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure adding and removing policies from users and groups #4428

Merged
merged 31 commits into from
Mar 18, 2023

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Dec 31, 2022

Description

Changes mc admin policy add to mc admin policy create
Replaces mc admin policy (set|unset|update) commands with mc admin policy (attach|detach)
Adds mc admin policy entities

Motivation and Context

Implements changes requested in issues below, with some modifications requested offline.

resolves #4272
resolves #4273
resolves #4274

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@taran-p taran-p marked this pull request as ready for review January 1, 2023 02:49
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change FWIW

@harshavardhana
Copy link
Member

PTAL @donatello

Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taran-p we are more or less ready to take this PR in with minor changes - please resolve the conflicts.

cmd/admin-policy-update.go Outdated Show resolved Hide resolved
cmd/admin-policy-unset.go Outdated Show resolved Hide resolved
cmd/admin-policy-set.go Outdated Show resolved Hide resolved
@donatello
Copy link
Member

PTAL @harshavardhana @kannappanr this is ready to merge

This is a breaking change and we should note it in the release notes in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants