-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure adding and removing policies from users and groups #4428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change FWIW
PTAL @donatello |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taran-p we are more or less ready to take this PR in with minor changes - please resolve the conflicts.
PTAL @harshavardhana @kannappanr this is ready to merge This is a breaking change and we should note it in the release notes in the next release. |
This reverts commit d1f36de.
Description
Changes
mc admin policy add
tomc admin policy create
Replaces
mc admin policy (set|unset|update)
commands withmc admin policy (attach|detach)
Adds
mc admin policy entities
Motivation and Context
Implements changes requested in issues below, with some modifications requested offline.
resolves #4272
resolves #4273
resolves #4274
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)