[wip] Add --insecure flag to skip certificate validation #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
force-pushed
the
add_insecure_flag
branch
from
e0b9f6a to
e546a0d
Compare
| @@ -47,6 +47,10 @@ var globalFlags = []cli.Flag{ | |||
| Name: "debug", | |||
| Usage: "Enable debugging output.", | |||
| }, | |||
| cli.BoolFlag{ | |||
| Name: "insecure", | |||
| Usage: "Skip SSl certificate verification.", | |||
Current coverage is 8.94% (diff: 13.95%)@@ master #1814 diff @@
========================================
Files 77 77
Lines 5817 5903 +86
Methods 0 0
Messages 0 0
Branches 0 0
========================================
+ Hits 525 528 +3
- Misses 5162 5244 +82
- Partials 130 131 +1
|
vadmeste
force-pushed
the
add_insecure_flag
branch
from
e546a0d to
6d05544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remarks:
*) I upgraded to session v8 because we have the new insecure flag
*) I print certificate information when --debug is enabled.. otherwise I guess it will be just annoying for the user to always see it