rm: add timebased delete and object list from stdin #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 8.78% (diff: 0.00%)@@ master #1837 diff @@
========================================
Files 77 77
Lines 5957 6022 +65
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 529 529
- Misses 5297 5362 +65
Partials 131 131
|
|
|
||
| // Check whether object is created older than given time only if older is >= one hour. | ||
| if older >= defaultOlderTime { | ||
| now := time.Now() |
There was a problem hiding this comment.
We should use 'time.Now().UTC()'
balamurugana
force-pushed
the
devel
branch
3 times, most recently
from
225460d to
8c3df4b
Compare
ping @balamurugana can you address the last comment? |
* Add multi-delete support by taking object list from stdin * Add support to `rm` to remove objects older than given time * Add --prefix flag to differenciate prefix and target names. Fixes minio#1827 minio#1828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rmto remove objects older than given timeFixes #1827 #1828