Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp/mirror: Use proper paths for windows during copyObject. #1897

Merged
merged 1 commit into from
Nov 27, 2016

Conversation

harshavardhana
Copy link
Member

Fixes #1857

@codecov-io
Copy link

codecov-io commented Nov 26, 2016

Current coverage is 8.65% (diff: 0.00%)

Merging #1897 into master will decrease coverage by <.01%

@@            master     #1897   diff @@
========================================
  Files           77        77          
  Lines         6298      6300     +2   
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           545       545          
- Misses        5624      5626     +2   
  Partials       129       129          

Powered by Codecov. Last update 0a42e29...f3f44cf

Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally on a windows laptop and mc cp works as expected with this change.

@harshavardhana
Copy link
Member Author

This fix is complete for the present form of path handling, what we need to do here is fix the newURL() to always provide paths with "/" not with "\" in them. Currently i see that mc requires an overhaul in terms of path handling across the board which will do subsequently after this merge. Such a change needs to proceed before we bring in mc admin capabilities.

@krishnasrinivas krishnasrinivas merged commit 2412aae into minio:master Nov 27, 2016
@harshavardhana harshavardhana deleted the fixes-windows branch November 27, 2016 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants