mirror: Avoid flushing session to disk on each i/o operation. #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 8.42% (diff: 0.00%)@@ master #1909 diff @@
========================================
Files 77 77
Lines 6410 6412 +2
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 540 540
- Misses 5739 5741 +2
Partials 131 131
|
harshavardhana
force-pushed
the
fix-performance
branch
from
f4d9f5e to
22de0e3
Compare
The problem was for each read from statusCh we were writing to session file again and also syncing to disk. This adds severe performance problems. Fixes minio#1908
harshavardhana
force-pushed
the
fix-performance
branch
from
22de0e3 to
fe64a05
Compare
harshavardhana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was for each read from statusCh we were writing
to session file again and also syncing to disk. This adds
severe performance problems.
Fixes #1908