enable static build releases with CGO_ENABLED=0 #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
cgo-enabled
branch
from
fc4738c to
8a60239
Compare
Current coverage is 8.72% (diff: 100%)@@ master #1935 diff @@
========================================
Files 77 77
Lines 6399 6399
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 558 558
Misses 5708 5708
Partials 133 133
|
|
@harshavardhana does this mean we don't put a downloadable |
|
Yes @krishnasrinivas since brew is easier and recommended. |
harshavardhana
force-pushed
the
cgo-enabled
branch
2 times, most recently
from
7f2270f to
a548d4e
Compare
Also removing darwin build, since we do brew install. Removing solaris since it doesn't build anymore. Fixes minio#1933
harshavardhana
force-pushed
the
cgo-enabled
branch
from
a548d4e to
00970e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removing darwin build, since we do brew install.
Removing solaris since it doesn't build anymore.
Fixes #1933