Add policy links command #1943
Merged
Add policy links command #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 8.53% (diff: 0.00%)@@ master #1943 diff @@
========================================
Files 82 82
Lines 6508 6559 +51
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 560 560
- Misses 5814 5865 +51
Partials 134 134
|
vadmeste
force-pushed
the
add_links_cmd
branch
2 times, most recently
from
3ee7f0d to
c7a0376
Compare
|
This PR is ready for review, the only existing problem is that it accepts --recursive and --json flag when they are before 'links' command and not after, let's discuss other issues if found first. |
harshavardhana
requested changes
Jan 4, 2017
| 6. List policies set to a specified bucket. | ||
| $ mc {{.Name}} list s3/shared | ||
|
|
||
| 7. List public objects recursively. |
There was a problem hiding this comment.
"List public object URLs recursively."
| // policyLinksMessage is container for policy links command | ||
| type policyLinksMessage struct { | ||
| Status string `json:"status"` | ||
| FullURL string `json:"fullURL"` |
| msg := policyLinksMessage{} | ||
| msg.Status = "success" | ||
| // Convert any os specific delimiters to "/". | ||
| msg.FullURL = filepath.ToSlash(content.URL.String()) |
There was a problem hiding this comment.
Don't do 'ToSlash' for URLs on windows the output will have '' which is unexpected.
| // Convert any os specific delimiters to "/". | ||
| msg.FullURL = filepath.ToSlash(content.URL.String()) | ||
| if content.Type.IsDir() { | ||
| msg.Type = "folder" |
There was a problem hiding this comment.
We can skip the 'CommonPrefix' since that is not useful in downloading the object itself.
There was a problem hiding this comment.
We can remove the Type itself it just prints fully qualified object URLs.
vadmeste
force-pushed
the
add_links_cmd
branch
from
c7a0376 to
ad73e92
Compare
|
All comments are addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1873