Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror: Quit after showing all progressbar updates #2020

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

vadmeste
Copy link
Member

mc can quit when mirror terminates but progress bar is not able
to show all made progress. This commit makes mc waits until all updates
are sent to the status channel.

mc can quit when mirror terminates but progress bar is not able
to show all made progress. This commit makes mc waits until all updates
are sent to the status channel.
@codecov-io
Copy link

Codecov Report

Merging #2020 into master will decrease coverage by -0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2020      +/-   ##
=========================================
- Coverage    8.59%   8.58%   -0.01%     
=========================================
  Files          86      86              
  Lines        6670    6674       +4     
=========================================
  Hits          573     573              
- Misses       5960    5964       +4     
  Partials      137     137
Impacted Files Coverage Δ
cmd/mirror-main.go 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e44b9...785ec5c. Read the comment docs.

@harshavardhana harshavardhana merged commit 7483cde into minio:master Feb 17, 2017
@vadmeste vadmeste deleted the fix_progress_bar_last_update branch May 29, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants