fs stat(): Return dir stat with incomplete flag #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs.Stat() returns an error when the path corresponds to a directory and incomplete flag is enabled. This PR follows S3 client behavior and fixes the behavior.
harshavardhana
approved these changes
Mar 20, 2017
Codecov Report
@@ Coverage Diff @@
## master #2078 +/- ##
=========================================
+ Coverage 8.4% 8.44% +0.04%
=========================================
Files 92 92
Lines 6814 6817 +3
=========================================
+ Hits 573 576 +3
Misses 6104 6104
Partials 137 137
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.Stat() returns an error when the path corresponds to
a directory and incomplete flag is enabled. This PR follows
S3 client behavior and fixes the behavior.
Fixes #2064