share: Download shares url of exact prefix #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
changed the title
When recursive flag is not specified, share download will only generate download urls for the object which has the exact same prefix.
vadmeste
force-pushed
the
download_share_one
branch
from
008d4b2 to
71a6095
Compare
Codecov Report
@@ Coverage Diff @@
## master #2096 +/- ##
=========================================
- Coverage 8.59% 8.57% -0.02%
=========================================
Files 92 92
Lines 6748 6762 +14
=========================================
Hits 580 580
- Misses 6033 6047 +14
Partials 135 135
Continue to review full report at Codecov.
|
harshavardhana
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recursive flag is not specified, share download will only
generate download urls for the object which has the exact same
prefix.
Fixes #2088