Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp: Set exit status to 1 for any error #2127

Merged
merged 1 commit into from
Apr 15, 2017

Conversation

vadmeste
Copy link
Member

Non fatal errors during copy were not setting mc exit code with 1. This
commit fixes the behavior.

Fixes #2112

Non fatal errors during copy were not setting mc exit code with 1. This
commit fixes the behavior.
@vadmeste vadmeste requested a review from harshavardhana April 14, 2017 21:15
@codecov-io
Copy link

Codecov Report

Merging #2127 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2127   +/-   ##
======================================
  Coverage    8.52%   8.52%           
======================================
  Files          91      91           
  Lines        6806    6806           
======================================
  Hits          580     580           
  Misses       6091    6091           
  Partials      135     135
Impacted Files Coverage Δ
cmd/cp-main.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f3ffa...2e2ea03. Read the comment docs.

@harshavardhana harshavardhana merged commit 313d0a3 into minio:master Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mc does not always return non-zero status after errors
3 participants