mb: Update pkg to retry mb with unmatched region #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2139 +/- ##
======================================
Coverage 8.89% 8.89%
======================================
Files 92 92
Lines 6837 6837
======================================
Hits 608 608
Misses 6094 6094
Partials 135 135Continue to review full report at Codecov.
|
cmd/client-s3.go
Outdated
| @@ -762,6 +763,11 @@ func (c *s3Client) MakeBucket(region string) *probe.Error { | |||
| } | |||
| e := c.api.MakeBucket(bucket, region) | |||
| if e != nil { | |||
| // Enhance error message when invalid region error is received | |||
| if errResp, ok := e.(minio.ErrorResponse); ok && errResp.Code == "InvalidRegion" { | |||
| errResp.Message = fmt.Sprintf("The server rejected `%s` region. Kindly pass the correct region value using `--region` flag.", region) | |||
There was a problem hiding this comment.
We actually retry with the Region returned in the headers. not sure if this is needed..
|
This PR is waiting on - minio/minio-go#665 |
harshavardhana
requested changes
Apr 25, 2017
vadmeste
changed the title
harshavardhana
approved these changes
Apr 29, 2017
harshavardhana
approved these changes
Apr 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2107