Add Docker release files for mc #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2182 +/- ##
======================================
Coverage 9.15% 9.15%
======================================
Files 93 93
Lines 6906 6906
======================================
Hits 632 632
Misses 6140 6140
Partials 134 134Continue to review full report at Codecov.
|
|
Built locally using https://blog.hypriot.com/post/setup-simple-ci-pipeline-for-arm-images/ works fine. |
harshavardhana
requested changes
Jun 14, 2017
Dockerfile.release
Outdated
| @@ -0,0 +1,12 @@ | |||
| FROM alpine:3.5 | |||
|
|
|||
| WORKDIR /go/src/app | |||
There was a problem hiding this comment.
You don't need this.. @nitisht also you can follow Dockerfile.release
apk add --no-cache ca-certificates && \
apk add --no-cache --virtual .build-deps curl && \
We need ca-certificates as well.
echo 'hosts: files mdns4_minimal [NOTFOUND=return] dns mdns4' >> /etc/nsswitch.conf && \
Dockerfile.release
Outdated
| curl https://dl.minio.io/client/mc/release/linux-amd64/mc > /usr/bin/mc && \ | ||
| chmod +x /usr/bin/mc | ||
|
|
||
| ENTRYPOINT ["mc"] |
Dockerfile.release.aarch64
Outdated
|
|
||
| WORKDIR /go/src/app | ||
|
|
||
| COPY . /go/src/app |
Dockerfile.release.armhf
Outdated
| FROM resin/armhf-alpine:3.5 | ||
|
|
||
| WORKDIR /go/src/app | ||
|
|
nitisht
force-pushed
the
dockerfile-update
branch
from
2ac29e2 to
3faddf3
Compare
|
Updated as per your comments @harshavardhana Also as discussed, did not use |
- New Dockerfile will be used for mc release images. - Statically built binary is downloaded from dl.minio.io website and used in the docker image.
nitisht
force-pushed
the
dockerfile-update
branch
from
3faddf3 to
1ad9516
Compare
harshavardhana
approved these changes
Jun 14, 2017
krishnasrinivas
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These Dockerfile(s) will be used for
mcrelease images for various platforms.Statically built binary is downloaded from dl.minio.io website and used in the docker image