Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow minio-go to validate bucket names. #2183

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

harshavardhana
Copy link
Member

Related change in minio-go minio/minio-go#708

Fixes #2157

@codecov-io
Copy link

codecov-io commented Jun 16, 2017

Codecov Report

Merging #2183 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2183      +/-   ##
=========================================
- Coverage    9.15%   9.14%   -0.01%     
=========================================
  Files          93      93              
  Lines        6906    6888      -18     
=========================================
- Hits          632     630       -2     
+ Misses       6140    6128      -12     
+ Partials      134     130       -4
Impacted Files Coverage Δ
cmd/client-s3.go 14.2% <ø> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32b1ea...8b34cc5. Read the comment docs.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

@vadmeste vadmeste merged commit 1a85611 into minio:master Jun 21, 2017
@harshavardhana harshavardhana deleted the valid-bucket-name branch June 21, 2017 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants