mirror/diff: Ignore errors during objectDifference. #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files which are broken in symlink, not accessible and unsupported should be ignored. We should proceed to next object. Fixes minio#2199
Codecov Report
@@ Coverage Diff @@
## master #2200 +/- ##
======================================
Coverage 9.12% 9.12%
======================================
Files 93 93
Lines 6906 6906
======================================
Hits 630 630
Misses 6146 6146
Partials 130 130
Continue to review full report at Codecov.
|
|
why is this blocked @deekoder ? |
deekoder
requested review from
vadmeste and
balamurugana
and removed request for
vadmeste
|
Any reviews? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files which are broken in symlink, not accessible
and unsupported should be ignored. We should proceed
to next object.
Fixes #2199