-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
share: Presign objects under a dir prefix #2215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2215 +/- ##
=========================================
- Coverage 8.88% 8.87% -0.01%
=========================================
Files 93 93
Lines 9028 9033 +5
=========================================
Hits 802 802
- Misses 8099 8104 +5
Partials 127 127
Continue to review full report at Codecov.
|
@vadmeste, I have the following namespace,
When I run
and
|
@krisis, I fixed the issue now. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vadmeste The help message still needs to be changed.
From now on, when the user specifies to share a prefix which represents a directory, all objects under that directory will be shared without having to check for --recursive flag. If the latter is specified, all objects in all subdirs will be shared.
@krisis, help text updated. Please take a look again. |
From now on, when the user specifies to share a prefix which represents
a directory, all objects under that directory will be shared without
having to check for --recursive flag. If the latter is specified, all
objects in all subdirs will be shared.
Fixed #2204