Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendorize new changes from minio-go #2227

Merged
merged 1 commit into from
Jul 30, 2017

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jul 26, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 26, 2017

Codecov Report

Merging #2227 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2227   +/-   ##
======================================
  Coverage    8.88%   8.88%           
======================================
  Files          93      93           
  Lines        9028    9028           
======================================
  Hits          802     802           
  Misses       8099    8099           
  Partials      127     127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9401d5...50b71db. Read the comment docs.

@deekoder deekoder requested review from vadmeste and krisis July 26, 2017 18:57
@harshavardhana harshavardhana force-pushed the copy-object-meta branch 3 times, most recently from 11a89fe to 88b7f51 Compare July 27, 2017 22:48
@harshavardhana harshavardhana changed the title client/s3: Get() should return metadata. vendorize new changes from minio-go Jul 27, 2017
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@harshavardhana
Copy link
Member Author

We can merge this @deekoder

@deekoder deekoder merged commit 3e2c3fc into minio:master Jul 30, 2017
@harshavardhana harshavardhana deleted the copy-object-meta branch July 30, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants