Rename the snap to minio-client #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In linux, mc is midnight commander. In the traditional linux distro world, name conflicts are forbidden. Because we are trying to make this decentralized and self-serving, we need less strict rules. For this, we added the concept of aliases. Then the user can decide what application owns the mc name. You could make a claim for the mc name, and keep it. But I think it would be less confusing for existing linux users to rename the snap and use mc as an alias. I would love your feedback about this feature. Please let me know what do you think. Also, this needs somebody from your org to register the new name in build.snapcraft.io to get the continuous delivery working.
Codecov Report
@@ Coverage Diff @@
## master #2243 +/- ##
======================================
Coverage 9.36% 9.36%
======================================
Files 98 98
Lines 9193 9193
======================================
Hits 861 861
Misses 8199 8199
Partials 133 133Continue to review full report at Codecov.
|
Yes this change is fine since alias approach sounds easier. |
harshavardhana
approved these changes
Aug 24, 2017
|
Thanks for the merge :) Now you need to register the new name. You can do it from https://dashboard.snapcraft.io, or with: |
harshavardhana
pushed a commit
that referenced
this pull request
Aug 31, 2017
In linux, mc is midnight commander. In the traditional linux distro world, name conflicts are forbidden. Because we are trying to make this decentralized and self-serving, we need less strict rules. For this, snap has a concept of aliases. Then the user can decide what application owns the mc name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In linux, mc is midnight commander.
In the traditional linux distro world, name conflicts are forbidden. Because we are trying to make this decentralized and self-serving, we need less strict rules. For this, we added the concept of aliases. Then the user can decide what application owns the mc name.
You could make a claim for the mc name, and keep it. But I think it would be less confusing for existing linux users to rename the snap and use mc as an alias.
I would love your feedback about this feature. Please let me know what do you think. Also, this needs somebody from your org to register the new name in build.snapcraft.io to get the continuous delivery working.