Fix and honor --json flag for find command. #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2263 +/- ##
=========================================
- Coverage 9.08% 9.07% -0.01%
=========================================
Files 100 100
Lines 9598 9607 +9
=========================================
Hits 872 872
- Misses 8595 8604 +9
Partials 131 131
Continue to review full report at Codecov.
|
harshavardhana
force-pushed
the
fix-find
branch
from
14125ca to
98b3a32
Compare
balamurugana
requested changes
Oct 3, 2017
| stage/ | ||
| mc |
| @@ -43,21 +42,17 @@ import ( | |||
|
|
|||
| // findMSG holds JSON and string values for printing | |||
| type findMSG struct { | |||
There was a problem hiding this comment.
I think you have a consistent name like findMessage
There was a problem hiding this comment.
Not part of this PR. Needs a cleanup in separate PR.
Currently `mc find` didn't honor `--json` flag properly, this PR addresses that. Additionally also take care of `List` returning errors and handle them appropriately. Fixes minio#2252
harshavardhana
force-pushed
the
fix-find
branch
from
98b3a32 to
d60194e
Compare
balamurugana
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
mc finddidn't honor--jsonflag properly,this PR addresses that.
Additionally also take care of
Listreturning errorsand handle them appropriately.
Fixes #2252