Add context in Put api call for cp/mirror #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2291 +/- ##
==========================================
- Coverage 10.65% 10.64% -0.01%
==========================================
Files 100 100
Lines 9632 9640 +8
==========================================
Hits 1026 1026
- Misses 8471 8479 +8
Partials 135 135
Continue to review full report at Codecov.
|
harshavardhana
requested changes
Oct 17, 2017
cmd/common-methods.go
Outdated
| @@ -105,7 +106,9 @@ func putTargetStream(alias string, urlStr string, reader io.Reader, size int64, | |||
| if err != nil { | |||
| return 0, err.Trace(alias, urlStr) | |||
| } | |||
| n, err := targetClnt.Put(reader, size, metadata, progress) | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
| defer cancel() | |||
There was a problem hiding this comment.
We can combine this cancel with trapCh so that if we do get a signal like CTRL-C <-trapCh we cleanly exit.
harshavardhana
approved these changes
Oct 18, 2017
krisis
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #2255. This PR passes context in mc Put api calls so that request cancellation with context