fix JSON format error in functional test #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2294 +/- ##
======================================
Coverage 10.6% 10.6%
======================================
Files 100 100
Lines 9675 9675
======================================
Hits 1026 1026
Misses 8514 8514
Partials 135 135Continue to review full report at Codecov.
|
poornas
approved these changes
Oct 24, 2017
nitisht
reviewed
Oct 24, 2017
Previously `error` field is not populated properly due to double formatting error message into JSON string. This patch fixes the issue by avoid second time formatting in `printf` command.
balamurugana
force-pushed
the
fix-functional-test-error
branch
from
f31c233 to
eedebfd
Compare
updated |
nitisht
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
errorfield is not populated properly due to doubleformatting error message into JSON string. This patch fixes the issue
by avoid second time formatting in
printfcommand.