Rearrange exclude code to filter source and target URLs #2322
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2322 +/- ##
==========================================
- Coverage 10.83% 10.82% -0.01%
==========================================
Files 102 102
Lines 7706 7711 +5
==========================================
Hits 835 835
- Misses 6736 6741 +5
Partials 135 135
Continue to review full report at Codecov.
|
| continue | ||
| } | ||
|
|
||
| tgtSuffix := strings.TrimPrefix(diffMsg.SecondURL, targetURL) |
There was a problem hiding this comment.
It is easy to understand: 'please exclude some files in source when mirroring'.. but it is not easy to understand 'please exclude some files in target when mirroring`.. Is there any useful use case for the latter scenario ?
There was a problem hiding this comment.
@vadmeste , if --remove flags is passed, the files in the target will be removed. So, exclude options should be applied to both source and target.
There was a problem hiding this comment.
@vadmeste , if --remove flags is passed, the files in the target will be removed. So, exclude options should be applied to both source and target.
okay, then you need to update --exclude help message.
Move exclude code handler to mirror-url and mirror-main Fixes minio#2319
kannappanr
force-pushed
the
exclude_fix
branch
from
13d558a to
0a1f7b9
Compare
Move exclude code handler to mirror-url and mirror-main
Fixes #2319