fix missing metadata in stat cmd #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2348 +/- ##
==========================================
+ Coverage 10.76% 10.76% +<.01%
==========================================
Files 103 103
Lines 7723 7721 -2
==========================================
Hits 831 831
+ Misses 6758 6756 -2
Partials 134 134
Continue to review full report at Codecov.
|
| @@ -144,9 +144,6 @@ func doStat(clnt Client, isRecursive bool, targetAlias, targetURL string) error | |||
| continue | |||
| } | |||
| url := targetAlias + getKey(content) | |||
| if !isAliasURLDir(targetURL) { | |||
| url = content.URL.Path | |||
| } | |||
There was a problem hiding this comment.
doStat(clnt Client, isRecursive bool, targetAlias, targetURL string) looks like targetURL is not used ... you can remove this as well.
mc stat without --r is missing metadata for stat on objectname
krishnasrinivas
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mc stat without --r is missing metadata for stat on objectname.