Updating minio-go library #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatello
approved these changes
Aug 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #2506 +/- ##
==========================================
- Coverage 10.66% 10.65% -0.01%
==========================================
Files 106 106
Lines 10672 10672
==========================================
- Hits 1138 1137 -1
- Misses 9384 9385 +1
Partials 150 150
Continue to review full report at Codecov.
|
ebozduman
reviewed
Aug 8, 2018
| if err != nil { | ||
| return err | ||
| } | ||
| if resp != nil { |
There was a problem hiding this comment.
It could be:
if resp != nil && resp.StatusCode != http.StatusOK{
There was a problem hiding this comment.
all of these should be addressed in minio-go @ebozduman open an issue there.
| @@ -223,6 +223,7 @@ var supportedHeaders = []string{ | |||
| "content-disposition", | |||
| "content-language", | |||
| "x-amz-website-redirect-location", | |||
| "expires", | |||
There was a problem hiding this comment.
How is this change related to this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes latest minio-go fixes.